Skip to content

Exit serving container when process-based cron fails #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2020
Merged

Exit serving container when process-based cron fails #1560

merged 2 commits into from
Nov 16, 2020

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Nov 16, 2020 •
edited
Loading

Fixes #1552.

checklist:

  • run make test and make lint
  • test manually by running an iris classifier and raising an exception within the cron's loop

@RobertLucian RobertLucian merged commit 79b0e96 into master Nov 16, 2020
@RobertLucian RobertLucian deleted the fix/serving-container-not-exiting branch November 16, 2020 23:28
deliahu pushed a commit that referenced this pull request Nov 19, 2020
@RobertLucian @deliahu
Exit serving container when process-based cron fails (#1560)
ebe6499 
(cherry picked from commit 79b0e96)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serving container doesn't stop when a multi-processed cron throws exception
2 participants
@RobertLucian @deliahu