Skip to content

Fix cluster resizing via cortex cluster configure #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Fix cluster resizing via cortex cluster configure #1568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0216eae
Fix cluster risizing via cortex cluster configure
deliahu Nov 18, 2020
69141de
Merge branch 'master' into fix/cluster-resize
deliahu Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions manager/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,12 @@ function cluster_configure() {
setup_secrets
echo "✓"

# this is necessary since max_instances may have been updated
echo -n "￮ configuring autoscaling "
python render_template.py $CORTEX_CLUSTER_CONFIG_FILE manifests/cluster-autoscaler.yaml.j2 > /workspace/cluster-autoscaler.yaml
kubectl apply -f /workspace/cluster-autoscaler.yaml >/dev/null
echo "✓"

restart_operator

validate_cortex
Expand Down
4 changes: 4 additions & 0 deletions manager/manifests/cluster-autoscaler.yaml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,3 +199,7 @@ spec:
- name: ssl-certs
hostPath:
path: "/etc/ssl/certs/ca-bundle.crt"
strategy:
type: RollingUpdate
rollingUpdate:
maxSurge: 0 # necessary because there may not be enough room on the operator node for a rolling update