Skip to content

Fix no local TF model accessible with LR enabled #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2020
Merged

Fix no local TF model accessible with LR enabled #1668

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7705a6a
Fix no local TF model accessible with LR enabled
RobertLucian Dec 8, 2020
43ab334
Run lint
RobertLucian Dec 8, 2020
5694205
Merge branch 'master' into fix/local-tf-lr
RobertLucian Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/workloads/cortex/lib/model/cron.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1236,6 +1236,9 @@ def _load_local_models(self) -> None:
)
self._reset_when_tfs_unresponsive()
return None
self._old_ts_state[f"{model_name}-{model_version}"] = int(
datetime.datetime.now(datetime.timezone.utc).timestamp()
)

def _is_this_a_newer_model_id(self, model_id: str, timestamp: int) -> bool:
return model_id in self._old_ts_state and self._old_ts_state[model_id] < timestamp
Expand Down