Skip to content

Move model-related fields in a subfield for the Python Predictor #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Dec 22, 2020
Merged

Move model-related fields in a subfield for the Python Predictor #1702

merged 28 commits into from
Dec 22, 2020

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Dec 16, 2020 •
edited by deliahu
Loading

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)

RobertLucian
RobertLucian commented Dec 16, 2020
View reviewed changes
@RobertLucian RobertLucian mentioned this pull request Dec 18, 2020
Merged
2 tasks
@RobertLucian RobertLucian requested a review from deliahu December 18, 2020 01:27
deliahu
deliahu approved these changes Dec 19, 2020
View reviewed changes
@RobertLucian RobertLucian merged commit 56094bf into master Dec 22, 2020
@RobertLucian RobertLucian deleted the improvement/python-api-spec branch December 22, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobertLucian @deliahu @vishalbollu