Don't exit with non-zero code if -o is set to json for patch command #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem with the patch command where if there's an error reported by the operator (in
deployResults) and if the-oflag is set tojson, the CLI shouldn't exit with a non-zero code as that will make the Python Client read whatever is on stderr, as opposed to reading stdout.This is a stop-gap solution for now. There's another problem as well when a
patchis executed on an API of a different kind, which is not permissible - the error message is not suggestive, and we'll have that fixed in a different PR.checklist:
make testandmake lint