Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python client not respecting CORTEX_CLI_CONFIG_DIR environment variable for client-id.txt #1953

Merged
merged 4 commits into from Mar 15, 2021

Conversation

jackmpcollins
Copy link
Contributor

Currently, the python client does not respect the CORTEX_CLI_CONFIG_DIR environment variable when locating "client-id.txt" while creating the default scope for sentry. This results in two "client-id.txt" files with different uuids when this environment variable is set - one created by the cortex CLI in the specified directory and the other created by the python client in ~/.cortex. This PR fixes this by using cli_config_dir() to locate client-id.txt when creating the sentry default scope.


checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)
  • cherry-pick into release branches if applicable
  • alert the dev team if the dev environment changed

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@miguelvr miguelvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguelvr
Copy link
Collaborator

@jackmpcollins just run make format to fix the linting errors

Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Jack! LGTM!

@miguelvr miguelvr merged commit 78c253e into cortexlabs:master Mar 15, 2021
@jackmpcollins jackmpcollins deleted the fix/sentry_cli_config_dir branch March 15, 2021 17:23
@vishalbollu vishalbollu added this to the 0.31 milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants