Fix Python client not respecting CORTEX_CLI_CONFIG_DIR environment variable for client-id.txt #1953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the python client does not respect the
CORTEX_CLI_CONFIG_DIR
environment variable when locating"client-id.txt"
while creating the default scope for sentry. This results in two"client-id.txt"
files with different uuids when this environment variable is set - one created by the cortex CLI in the specified directory and the other created by the python client in~/.cortex
. This PR fixes this by usingcli_config_dir()
to locateclient-id.txt
when creating the sentry default scope.checklist:
make test
andmake lint
summary.md
(view in gitbook after merging)