Merge kubectl logs #227

vishalbollu · 2019-07-10T21:59:19Z

Closes #214 , #216

Checklist:

Run make test and make lint
Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)\
Update examples
Update documentation (add any new files to summary.md)
Merge to master
Cherry-pick into release branches if it's a bugfix
Check gitbook that docs look good and links function properly
Alert team if dev environment changed
Delete the branch once it's merged

cli/cmd/get.go

pkg/operator/workloads/logs.go

cli/cmd/get.go

pkg/operator/workloads/logs.go

vishalbollu added 2 commits July 10, 2019 21:54

Merge kubectl logs

5b64fe7

Remove unnecessary const

8167132

vishalbollu requested review from deliahu and 1vn July 10, 2019 21:59

deliahu reviewed Jul 11, 2019

View reviewed changes

Refactor code and add delete processes from ProcessMap

cf8869a

deliahu reviewed Jul 11, 2019

View reviewed changes

cli/cmd/get.go Outdated Show resolved Hide resolved

pkg/operator/workloads/logs.go Outdated Show resolved Hide resolved

vishalbollu added 2 commits July 11, 2019 18:34

Merge branch 'master' into merge-kubectl-logs

3335bef

Change since to tail

9d1b003

deliahu reviewed Jul 11, 2019

View reviewed changes

pkg/operator/workloads/logs.go Outdated Show resolved Hide resolved

Defer socketclosure

397f2b7

deliahu approved these changes Jul 11, 2019

View reviewed changes

deliahu merged commit c8ee7fd into master Jul 11, 2019

deliahu deleted the merge-kubectl-logs branch July 11, 2019 22:12

Provide feedback