Skip to content

Fix istio rate discrepancy in Grafana #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Fix istio rate discrepancy in Grafana #2418

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41e762e
Fix the request rate discrepancy on istio
RobertLucian Jan 12, 2022
501ab3a
Change specific to cortex ingresses
RobertLucian Jan 13, 2022
e96a46f
Merge branch 'master' into fix/istio-rate-discrepancy
RobertLucian Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions manager/manifests/prometheus-monitoring.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ spec:
apiVersion: monitoring.coreos.com/v1
kind: PodMonitor
metadata:
name: istio-stats
name: istio-ingress-stats
namespace: prometheus
labels:
monitoring.cortex.dev: "istio"
Expand All @@ -150,7 +150,7 @@ spec:
- { key: release, operator: In, values: [ "istio" ]}
namespaceSelector:
any: true
jobLabel: envoy-stats
jobLabel: istio-ingress-stats
podMetricsEndpoints:
- path: /stats/prometheus
interval: 15s
Expand All @@ -173,6 +173,11 @@ spec:
- sourceLabels: [ __meta_kubernetes_pod_name ]
action: replace
targetLabel: pod_name
- sourceLabels: [ __name__, __meta_kubernetes_pod_label_istio, __meta_kubernetes_pod_name ]
action: replace
regex: (istio_requests_total)?;(ingressgateway-apis)?;(.+)
replacement: $3
targetLabel: istioingress_podname
metricRelabelings:
- action: keep
sourceLabels: [__name__]
Expand All @@ -183,7 +188,7 @@ spec:
request_duration_milliseconds_count\
)"
- action: labelkeep
regex: (__name__|destination_service|response_code|le)
regex: (__name__|destination_service|response_code|le|istioingress_podname)

---

Expand Down