Skip to content

Rename env_name parameter in python client constructors #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2022
Merged

Rename env_name parameter in python client constructors #2431

merged 1 commit into from
Mar 4, 2022

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Feb 26, 2022

No description provided.

@deliahu deliahu requested a review from RobertLucian February 26, 2022 17:29
RobertLucian
RobertLucian approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@RobertLucian RobertLucian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deliahu deliahu merged commit 9f7a714 into master Mar 4, 2022
@deliahu deliahu deleted the python-client-env-name branch March 4, 2022 04:45
RobertLucian pushed a commit that referenced this pull request Sep 3, 2022
@deliahu @RobertLucian
Rename env_name parameter in python client constructors (#2431)
0008b79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertLucian RobertLucian RobertLucian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deliahu @RobertLucian