-
Notifications
You must be signed in to change notification settings - Fork 606
Add AWS resource pricing to cluster up confirmation message #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b629218
Update AWS resource metadata
deliahu 09465b3
Update servicequotas.go
deliahu 44f3b70
Add pricing to cluster up confirmation message
deliahu 7de2a8e
Update lib_cluster_config.go
deliahu d19d8a5
Update wording and casing
deliahu 88fc714
Merge branch 'master' of github.com:cortexlabs/cortex into aws-resour…
deliahu 4fed4ed
Fix typo
deliahu 5071965
Return errors in SpotInstancePrice()
deliahu c1d28ca
Merge branch 'master' into aws-resource-pricing
deliahu 3c5abc1
Merge branch 'master' into aws-resource-pricing
deliahu 309ed1a
Merge branch 'master' into aws-resource-pricing
deliahu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
/* | ||
Copyright 2019 Cortex Labs, Inc. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package aws | ||
|
||
import ( | ||
"math" | ||
"time" | ||
|
||
"github.com/aws/aws-sdk-go/aws" | ||
"github.com/aws/aws-sdk-go/aws/credentials" | ||
"github.com/aws/aws-sdk-go/aws/session" | ||
"github.com/aws/aws-sdk-go/service/ec2" | ||
"github.com/cortexlabs/cortex/pkg/lib/errors" | ||
s "github.com/cortexlabs/cortex/pkg/lib/strings" | ||
) | ||
|
||
// Returns the minimum of all AZs in the region, 0 if unable to retreive spot price for any reason | ||
func SpotInstancePrice(accessKeyID string, secretAccessKey string, region string, instanceType string) (float64, error) { | ||
sess, err := session.NewSession(&aws.Config{ | ||
Region: aws.String(region), | ||
DisableSSL: aws.Bool(false), | ||
Credentials: credentials.NewStaticCredentials(accessKeyID, secretAccessKey, ""), | ||
}) | ||
if err != nil { | ||
return 0, errors.WithStack(err) | ||
} | ||
|
||
svc := ec2.New(sess) | ||
|
||
result, err := svc.DescribeSpotPriceHistory(&ec2.DescribeSpotPriceHistoryInput{ | ||
InstanceTypes: []*string{aws.String(instanceType)}, | ||
ProductDescriptions: []*string{aws.String("Linux/UNIX")}, | ||
StartTime: aws.Time(time.Now()), | ||
}) | ||
|
||
min := math.MaxFloat64 | ||
|
||
for _, spotPrice := range result.SpotPriceHistory { | ||
if spotPrice == nil { | ||
continue | ||
} | ||
|
||
price, ok := s.ParseFloat64(*spotPrice.SpotPrice) | ||
if !ok { | ||
continue | ||
} | ||
|
||
if price < min { | ||
min = price | ||
} | ||
} | ||
|
||
if min == math.MaxFloat64 { | ||
return 0, ErrorNoValidSpotPrices(instanceType, region) | ||
} | ||
|
||
if min <= 0 { | ||
return 0, ErrorNoValidSpotPrices(instanceType, region) | ||
} | ||
|
||
return min, nil | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.