Skip to content

Generalize instance access check #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2019
Merged

Generalize instance access check #653

merged 2 commits into from
Dec 12, 2019

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Dec 12, 2019 •
edited
Loading

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cortex deploy --refresh)
  • Merge to master
  • Delete the branch once it's merged

@deliahu deliahu requested a review from vishalbollu December 12, 2019 19:53
@deliahu deliahu merged commit cf14a1c into master Dec 12, 2019
@deliahu deliahu deleted the instance-access branch December 12, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vishalbollu vishalbollu vishalbollu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deliahu @vishalbollu