Skip to content

Support multiple cortex clusters in the same region #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 16, 2019
Merged

Support multiple cortex clusters in the same region #661

merged 5 commits into from
Dec 16, 2019

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Dec 15, 2019

closes #660

checklist:

  • run make test and make lint
  • test end to end manually (i.e. build/push all images, restart operator, and run cortex deploy --refresh)
  • merge to master
  • delete the branch once it's merged

@deliahu deliahu requested a review from vishalbollu December 15, 2019 21:32
vishalbollu
vishalbollu reviewed Dec 16, 2019
View reviewed changes
Copy link
Contributor

@vishalbollu vishalbollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the cluster name show up when you cortex cluster down and cortex cluster update? If not I think we should add the cluster name in the messaging just to make it clear which cluster is being operated on

@deliahu deliahu merged commit b4f977b into master Dec 16, 2019
@deliahu deliahu deleted the multi-cluster branch December 16, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vishalbollu vishalbollu vishalbollu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple cortex clusters in the same AWS account and region
2 participants
@deliahu @vishalbollu