Skip to content

Prompt before deleting #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 20, 2019
Merged

Prompt before deleting #692

merged 4 commits into from
Dec 20, 2019

Conversation

vishalbollu
Copy link
Contributor

closes #674

checklist:

  • run make test and make lint
  • test end to end manually (i.e. build/push all images, restart operator, and run cortex deploy --refresh)
  • update the examples
  • update the docs and add any new files to summary.md
  • merge to master
  • cherry-pick into release branches if applicable
  • check that the docs are up-to-date in gitbook
  • alert the dev team if the dev environment changed
  • delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu December 20, 2019 02:53
@vishalbollu vishalbollu merged commit 847688c into master Dec 20, 2019
@vishalbollu vishalbollu deleted the prompt-before-cx-delete branch December 20, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add confirmation for cortex delete
2 participants
@vishalbollu @deliahu