Skip to content

New PyTorch Example: Object detection in Images with R-CNN #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 12, 2020

Conversation

ArkinDharawat
Copy link
Contributor

Hey,

I have added a new PyTorch example that uses a pretrained Faster R-CNN for object detection. The labels returned are from the coco dataset. I use the same test image that's used in the image-classification example.

closes #


checklist:

  • run make test and make lint
  • test end to end manually (i.e. build/push all images, restart operator, and run cortex deploy --refresh)
  • update the examples
  • update the docs and add any new files to summary.md
  • merge to master
  • cherry-pick into release branches if applicable
  • check that the docs are up-to-date in gitbook
  • alert the dev team if the dev environment changed
  • delete the branch once it's merged

@claassistantio
Copy link

claassistantio commented Jan 12, 2020

CLA assistant check
All committers have signed the CLA.

ArkinDharawat and others added 2 commits January 12, 2020 19:53
Changes:

* Format code using [Black](https://pypi.org/project/black/)
* Extract coco labels to text file (since when Black formatted the array with a new line per item, it took up a lot of space)
* Update version warning in file comments
* Remove `print(config)`
Copy link
Member

@deliahu deliahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Arkin, this is an awesome example, thank you for your contribution!

I just pushed a few nit changes to your branch, e.g. I formatted with Black, and extracted coco_labels to a text file since after formatting it took up a fair amount of space in the Python file.

The code looks great, and thanks for your effort to match our existing examples (e.g. adding it to the appropriate README, and including the example README). Feel free to merge!

@ArkinDharawat
Copy link
Contributor Author

Hey David,

Thanks! However, I cannot merge since it says I do not have "write access" to the repository

@deliahu deliahu merged commit c9f22b6 into cortexlabs:master Jan 12, 2020
@deliahu
Copy link
Member

deliahu commented Jan 12, 2020

Ah I see, sorry for the confusion. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants