Skip to content

Do not remove cluster configuring if refresh fails #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 22, 2020
Merged

Do not remove cluster configuring if refresh fails #893

merged 4 commits into from
Mar 22, 2020

Conversation

vishalbollu
Copy link
Contributor

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)
  • update examples
  • update docs and add any new files to summary.md (view in gitbook after merging)
  • cherry-pick into release branches if applicable
  • alert the dev team if the dev environment changed

@vishalbollu vishalbollu requested a review from deliahu March 21, 2020 18:41
deliahu
deliahu approved these changes Mar 22, 2020
View reviewed changes
@vishalbollu vishalbollu merged commit 48a5656 into master Mar 22, 2020
@vishalbollu vishalbollu deleted the preserve-cluster-yaml-if-refresh-fails branch March 22, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalbollu @deliahu