Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using -ingester.ingester.max-transfer-retries with zero value ends with unexpected (?) result #1771

Closed
pstibrany opened this issue Nov 1, 2019 · 0 comments · Fixed by #1777
Closed

Using -ingester.ingester.max-transfer-retries with zero value ends with unexpected (?) result #1771

pstibrany opened this issue Nov 1, 2019 · 0 comments · Fixed by #1777

Comments

@pstibrany
Copy link
Contributor

One would assume that setting -ingester.ingester.max-transfer-retries to zero disables transfers, when in fact it enables infinite number of retries instead. This should either be documented or fixed.

Reason for this behaviour is that -ingester.ingester.max-transfer-retries value is passed as MaxRetries in BackOffConfig struct, where zero means infinite retries.
pstibrany added a commit to grafana/cortex that referenced this issue Nov 4, 2019
@pstibrany
If ingester.max-transfer-retries is set to 0, hand-over attempts are …
a9f0fb2 
…disabled.

Due to interaction with BackOffConfig.MaxRetries, zero value meant infinite number
of attempts, which is hardly ever a desired behaviour (with no ingester waiting to
accept a transfer, this would never end).

Fixed cortexproject#1771.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
@pstibrany pstibrany mentioned this issue Nov 4, 2019
Merged
gouthamve pushed a commit that referenced this issue Nov 5, 2019
@pstibrany @gouthamve
If ingester.max-transfer-retries is set to 0, hand-over attempts are … (
7e17b89 
#1777)

* If ingester.max-transfer-retries is set to 0, hand-over attempts are disabled.

Due to interaction with BackOffConfig.MaxRetries, zero value meant infinite number
of attempts, which is hardly ever a desired behaviour (with no ingester waiting to
accept a transfer, this would never end).

Fixed #1771.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

* Fixed typo
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>

* Fix ingester.max-transfer-retries argument name.

Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

If ingester.max-transfer-retries is set to 0, hand-over attempts are … grafana/cortex
1 participant
@pstibrany