Add OpenTracing stuff #148
Conversation
|
(I'm just pushing the changes to the scope vendored code back to scope) |
- Add grpc middleware to client and server - Emit spans from TimeRequestHistogram
|
Pay attention to the bits in:
Have tested extensively locally. |
| "github.com/mwitkow/go-grpc-middleware" | ||
| "github.com/opentracing-contrib/go-stdlib/nethttp" | ||
| "github.com/opentracing/opentracing-go" | ||
| "github.com/tomwilkie/loki/client" |
There was a problem hiding this comment.
After all we went through before, this really should be "weaveworks/loki".
There was a problem hiding this comment.
This is a personal project right now.
| prometheus.MustRegister(resourceWatcher) | ||
| } | ||
|
|
||
| tracer, err := loki.NewTracer(loki.DefaultConfig) |
There was a problem hiding this comment.
There should be command-line options for scrape intervals & timeouts.
There was a problem hiding this comment.
scrape intervals are defined by loki (as it is in prometheus).
There was a problem hiding this comment.
In Prometheus, they are defined in the configuration file. Here, we're using the defaults in Loki with no way of customizing them.
There was a problem hiding this comment.
I've literrally copied the exact way prometheus does this: https://github.com/tomwilkie/loki/blob/master/pkg/config/config.go
Are we talking cross purposes?
chunk/chunk_store.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| // TODO push ctx all the way through, so we can do cancellation (eventually!) |
So we can visualise query execution, to help with #132