added interfaces for store specific limits #1602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewStore method in pkg/storage uses Overrides type defined in Cortex itself. Added an interface to let consumers of that method pass any type which implements required methods This is done as part of way to let projects using Cortex, define their own limits Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
tomwilkie
approved these changes
Aug 22, 2019
gouthamve
approved these changes
Aug 22, 2019
bboreham
reviewed
Aug 27, 2019
pkg/chunk/composite_store.go
Outdated
| ) | ||
|
|
||
| // CompositeStoreLimits helps get Limits specific to Queries for Stores in CompositeStore | ||
| type CompositeStoreLimits interface { |
There was a problem hiding this comment.
This seems misnamed, since it's used in store, CompositeStore and seriesStore. Suggest renaming to StoreLimits.
Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NewStoremethod inpkg/storageuses Overrides type defined in Cortex itself.Added an interface to let consumers of that method pass any type which implements required methods returning Store specific limits.
This is done as part of way to let projects using Cortex, define their own limits
Signed-off-by: Sandeep Sukhani sandeep.d.sukhani@gmail.com