change: separate distributor into api and service module #3112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
pstibrany
approved these changes
Sep 1, 2020
pkg/cortex/modules.go
Outdated
| mm.RegisterModule(Distributor, t.initDistributor) | ||
| mm.RegisterModule(Distributor, nil) | ||
| mm.RegisterModule(DistributorAPI, t.initDistributorAPI) | ||
| mm.RegisterModule(DistributorService, t.initDistributorService) |
There was a problem hiding this comment.
DistributorService should use modules.UserInvisibleModule option.
pkg/cortex/modules.go
Outdated
| API: {Server}, | ||
| Ring: {API, RuntimeConfig, MemberlistKV}, | ||
| Overrides: {RuntimeConfig}, | ||
| Distributor: {DistributorService, DistributorAPI}, |
There was a problem hiding this comment.
Do we need both Distributor and DistributorAPI?
There was a problem hiding this comment.
I think the DistributorAPI can be removed and the route registration can be moved to the Distributor module
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #3109
TLDR: Querier will no longer host distributor endpoints
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]