Fix missing return after writing sharding error #3897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the error ends up getting overwritten/obscured by the `This should not happen` error handling. Signed-off-by: Nick Parker <nick@nickbp.com>
pracucci
approved these changes
Mar 3, 2021
pstibrany
approved these changes
Mar 3, 2021
|
I'll answer since Nick is sleeping ;-) We were working on integrating the alertmanager and ruler in Opstrace (opstrace/opstrace#430) the thread is rather long and show us stumbling around haha:-) We are working on cortex master and would rather use and test what comes out there since we are not in a rush. |
|
Fantastic!
Just keep in mind the alertmanager sharding is not ready yet. There are still missing pieces we're working on. Since the work is huge, we're splitting it up in many PRs which get progressively merged to |
|
yeah we disabled it:-) Thanks! |
roystchiang
pushed a commit
to roystchiang/cortex
that referenced
this pull request
Apr 6, 2022
At the moment the error ends up getting overwritten/obscured by the `This should not happen` error handling. Signed-off-by: Nick Parker <nick@nickbp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
At the moment the error ends up getting overwritten/obscured by the
This should not happenerror handling a few lines further down. This ensures that the original error isn't stomped on.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]