Fix integration TestSingleBinaryWithMemberlistScaling flaking. #4361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be highlighting an issue - raised as cortexproject#4360. This change just stops the test flaking until it can be fixed. Signed-off-by: Steve Simpson <steve.simpson@grafana.com>
pracucci
approved these changes
Jul 13, 2021
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
…xproject#4361) This appears to be highlighting an issue - raised as cortexproject#4360. This change just stops the test flaking until it can be fixed. Signed-off-by: Steve Simpson <steve.simpson@grafana.com> Signed-off-by: Alvin Lin <alvinlin@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fix integration TestSingleBinaryWithMemberlistScaling flaking.
This appears to be highlighting an issue - raised as #4360.
This change just stops the test flaking until it can be fixed.
Though the change essentially reduces the usefulness of the test, I would rather keep the test running as-is instead of skipping it or changing it too much, to avoid the test rotting.
Which issue(s) this PR fixes:
Fixes #4351
Checklist
Tests updatedDocumentation addedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]