Skip to content

Conversation

qinxx108
Copy link
Contributor

@qinxx108 qinxx108 commented Apr 8, 2022

What this PR does:

  1. add the integration with rulespostprocess func
  2. add the syncForState ability to solve issue mention here:Rulers HA #4435
  3. enable the ruler replication factor to be more than 1

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

qinxx108 and others added 2 commits April 13, 2022 11:27
Signed-off-by: Yijie Qin <qinyijie@amazon.com>
Signed-off-by: Yijie Qin <qinxiuxiu2016@gmail.com>
Signed-off-by: Yijie Qin <qinxiuxiu2016@gmail.com>
@qinxx108 qinxx108 force-pushed the qinyijie-ruler-HA branch from 8a5e31b to bfd3af0 Compare April 13, 2022 15:27
qinxx108 and others added 2 commits April 13, 2022 12:24
Signed-off-by: Yijie Qin <qinxiuxiu2016@gmail.com>
@qinxx108 qinxx108 force-pushed the qinyijie-ruler-HA branch from ce6bf0f to ec66fcf Compare April 13, 2022 23:41
@@ -9,6 +9,7 @@
* [FEATURE] Compactor: Add `-compactor.skip-blocks-with-out-of-order-chunks-enabled` configuration to mark blocks containing index with out-of-order chunks for no compact instead of halting the compaction
* [FEATURE] Querier/Query-Frontend: Add `-querier.per-step-stats-enabled` and `-frontend.cache-queryable-samples-stats` configurations to enable query sample statistics
* [FEATURE] Add shuffle sharding for the compactor #4433
* [ENHANCEMENT] Ruler: enable ruler HA by having replication factore more than 3. We will also use the prometheus RuleGroupPostProcessFunc to sync for state before each rule group evaluation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [ENHANCEMENT] Ruler: enable ruler HA by having replication factore more than 3. We will also use the prometheus RuleGroupPostProcessFunc to sync for state before each rule group evaluation
* [ENHANCEMENT] Ruler: enable ruler HA by having replication factore more than 3. We will also use the prometheus RuleGroupPostProcessFunc to sync for state before each rule group evaluation. #4712

@stale
Copy link

stale bot commented Aug 12, 2022

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 12, 2022
@@ -9,6 +9,7 @@
* [FEATURE] Compactor: Add `-compactor.skip-blocks-with-out-of-order-chunks-enabled` configuration to mark blocks containing index with out-of-order chunks for no compact instead of halting the compaction
* [FEATURE] Querier/Query-Frontend: Add `-querier.per-step-stats-enabled` and `-frontend.cache-queryable-samples-stats` configurations to enable query sample statistics
* [FEATURE] Add shuffle sharding for the compactor #4433
* [ENHANCEMENT] Ruler: enable ruler HA by having replication factore more than 3. We will also use the prometheus RuleGroupPostProcessFunc to sync for state before each rule group evaluation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

factor*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants