feat(alertmanager): add support for webex,discord,telegram receivers #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niclas Schad <niclas.schad@gmail.com>
Signed-off-by: Niclas Schad <niclas.schad@gmail.com>
nschad
changed the title
Signed-off-by: Niclas Schad <niclas.schad@gmail.com>
yeya24
reviewed
Aug 3, 2023
Signed-off-by: Niclas Schad <niclas.schad@gmail.com>
|
Thanks! LGTM. |
alanprot
approved these changes
Aug 3, 2023
rajagopalanand
pushed a commit
to rajagopalanand/rajagopalanand-cortex
that referenced
this pull request
Aug 3, 2023
…ortexproject#5493) * feat(alertmanager): add support for webex receivers Signed-off-by: Niclas Schad <niclas.schad@gmail.com> * feat(alertmanager): add support for telegram and discord Signed-off-by: Niclas Schad <niclas.schad@gmail.com> * fix docstring Signed-off-by: Niclas Schad <niclas.schad@gmail.com> * update CHANGELOG Signed-off-by: Niclas Schad <niclas.schad@gmail.com> --------- Signed-off-by: Niclas Schad <niclas.schad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
A user from the slack channel pointed out that his webex config was giving him an error even though it should be supported.
In PR #5276 the telegram receiver was properly validated but have we forgotten to add the telegram receiver to the
buildIntegrationsfunction? Otherwise I'm confused.Which issue(s) this PR fixes:
Upgrade to alertmanager v0.25 didn't include all new receivers.
Special notes
I did not test this as we don't use webex. I also don't have webex. However I checked the WebExConfig struct and each field should be supported by cortex (no file stuff), no special validation required.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]