Update Thanos objsstore #5515
Merged
Update Thanos objsstore #5515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
yeya24
reviewed
Aug 16, 2023
yeya24
reviewed
Aug 16, 2023
| if errors.Is(err, bucket.ErrCustomerManagedKeyAccessDenied) { | ||
| u.storesErrorsMu.Lock() | ||
| u.storesErrors[job.userID] = err | ||
| u.storesErrors[job.userID] = httpgrpc.Errorf(int(codes.PermissionDenied), "store error: %s", err) |
There was a problem hiding this comment.
Any reason we wrap this to httpgrpc error?
There was a problem hiding this comment.
Seems it is used in testing only?
There was a problem hiding this comment.
This get translated to a 4xx here:
cortex/pkg/querier/blocks_store_queryable.go
Lines 653 to 655 in 1d40924
This was causing 5xx in this case.
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]