Skip to content

Conversation

SungJin1212
Copy link
Member

@SungJin1212 SungJin1212 commented Oct 24, 2024

This PR adds json format otlp ingestion test. The decoder support both of proto and json format (https://github.com/prometheus/prometheus/blob/main/storage/remote/codec.go#L883). But, the existing test only covers the proto format ingestion.

This PR adds a test making sure the json format of the otlp push request also ingests well.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212 SungJin1212 force-pushed the Add-json-format-otlp-ingest-test branch from 550ec69 to d7de6f7 Compare October 24, 2024 07:45
@SungJin1212
Copy link
Member Author

SungJin1212 commented Oct 24, 2024

@friedrichg
Please let me know if other tests are necessary in the otlp ingestion :)

Copy link
Member

@friedrichg friedrichg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 24, 2024
@CharlieTLe CharlieTLe changed the title Add json format oltp ingestion test Add json format otlp ingestion test Oct 24, 2024
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks!

@yeya24 yeya24 merged commit 184ead9 into cortexproject:master Oct 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size/M type/tests
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants