Add query limiter support to parquet querier #6870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: yeya24 <benye@amazon.com>
Signed-off-by: yeya24 <benye@amazon.com>
harry671003
reviewed
Jul 11, 2025
harry671003
reviewed
Jul 11, 2025
harry671003
reviewed
Jul 11, 2025
Signed-off-by: yeya24 <benye@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds query limiter support to parquet querier. Supported limits are:
Additionally introduce new parquet querier specific limits:
parquet_max_fetched_row_count: Number of matched rows in Parquet before materializing any chunks so this might include series that doesn't actually have chunks in the time range.parquet_max_fetched_chunk_bytes: Total size of fetched Chunk column pages.parquet_max_fetched_data_bytes: Total size of fetched Label column pages + Chunk column pages.Ready for review but note that the upstream PR for parquet common is still not merged. prometheus-community/parquet-common#81.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]