New metric for ingester errors #6901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
SungJin1212
reviewed
Jul 23, 2025
pkg/ingester/instance_limits.go
Outdated
| @@ -13,6 +13,8 @@ var ( | |||
| errMaxSeriesLimitReached = errors.New("cannot add series: ingesters's max series limit reached") | |||
| errTooManyInflightPushRequests = errors.New("cannot push: too many inflight push requests in ingester") | |||
| errTooManyInflightQueryRequests = errors.New("cannot push: too many inflight query requests in ingester") | |||
|
|
|||
| pushErrTooManyInflightRequests = "errTooManyInflightRequests" | |||
There was a problem hiding this comment.
Thanks. I think we can omit 'err' from the reason label, since the metric name itself contains error.
Suggested change
| pushErrTooManyInflightRequests = "errTooManyInflightRequests" | |
| pushErrTooManyInflightRequests = "tooManyInflightRequests" |
Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
SungJin1212
approved these changes
Jul 23, 2025
rubywtl
pushed a commit
to rubywtl/cortex
that referenced
this pull request
Jul 23, 2025
* New metric for ingester errors Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com> * changelog Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com> * change error reason Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com> --------- Signed-off-by: Daniel Deluiggi <ddeluigg@amazon.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Introduce a new metric with reason from when ingester returns an error. Currently this will be useful for throttling customer on tooManyInflightRequests. We can expand for more error reasons as needed
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]