Update ring DynamoDB Client to write in a transaction when batching #6987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Tran <trananna@amazon.com>
Signed-off-by: Anna Tran <trananna@amazon.com>
Signed-off-by: Anna Tran <trananna@amazon.com>
Signed-off-by: Anna Tran <trananna@amazon.com>
yeya24
reviewed
Aug 28, 2025
| if item[version] != nil { | ||
| parsedVersion, err := strconv.ParseInt(*item[version].N, 10, 0) | ||
| if err != nil { | ||
| kv.logger.Log("msg", "failed to parse item version", "version", *item[version].N, "err", err) |
There was a problem hiding this comment.
What could go wrong if we failed to parse the version? Seems we just log but ignore the error
There was a problem hiding this comment.
The version will be set to 0 if we cannot parse the version. This will prevent updates to the DDB entry so there won't be any overwrites that are out of date but the instance won't be able to join the ring. I think that's ok, operators can intervene if that happens.
There was a problem hiding this comment.
Maybe for us to track lets add a metric when we get condition check failure error back. It can be a new ddb metric
There was a problem hiding this comment.
Good suggestion, updated
Signed-off-by: Anna Tran <trananna@amazon.com>
Signed-off-by: Anna Tran <trananna@amazon.com>
Signed-off-by: Daniel Blando <daniel@blando.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates the DynamoDB ring client to use versioning in it's KV store entries. Specifically
dynamodbItemstruct which holds the data from the queried item along with a version. If there is no version from DynamoDB for the item, the version defaults to an empty string.Which issue(s) this PR fixes:
Fixes #6986
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]