Fix error from resource based throttling to be retryable #6992
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
isRetryableError
from blocks_store_queryable checks if the error chain includeslimiter.ResourceLimitReachedError
struct:https://github.com/cortexproject/cortex/blob/master/pkg/querier/blocks_store_queryable.go#L1206-L1211
However, resource based limiter was not returning that error struct, hence this check was returning false.
Since the goal of resource based throttling is to protect subset of pods with high resource utilization, we do want to retry them on other pods.
Which issue(s) this PR fixes:
n/a
Testing:
Before the fix:
After the fix:
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
I didn't add changelog as this is a minor change in an experimental feature.