Skip to content

Conversation

Angith
Copy link

@Angith Angith commented Sep 1, 2025

What this PR does:

Which issue(s) this PR fixes:
Fixes #6941

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Angith and others added 2 commits August 31, 2025 23:47
@Angith Angith changed the title Parquetconverter/add sort columns feat(parquetconverter): add support for additional sort columns during Parquet file generation Sep 1, 2025
…Parquet file generation

Signed-off-by: Angith <angithcjjaas@gmail.com>
@Angith
Copy link
Author

Angith commented Sep 1, 2025

Hi @yeya24

I’ve raised this PR to add support for additional sort columns during Parquet file generation. A few points I wanted to clarify:

  • As per the contributing guide, I ran make doc, but it ended up deleting some other important documents. I also ran goimports, but it reformatted ~700 files, including files in the vendor folder. I assume these shouldn’t be committed, so I left those changes out. Could you please confirm the expected workflow here?
  • I’ve written unit tests for the new functionality and verified, but I haven’t yet tested the change end-to-end. Could you guide me on how to run the full end-to-end tests for Cortex to validate this change?

Thanks in advance for your guidance 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring sorting labels for Parquet Converter
1 participant