Make the per labelset series limit error message consistent with per user series error message #7015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user series error message Signed-off-by: Alvin Lin <alvinlin123@gmail.com>
alvinlin123
force-pushed
the
issue-7009-label-series-limit-err-msg-fix
branch
from
bf5147f to
904a106
Compare
justinjung04
reviewed
Sep 5, 2025
pkg/ingester/limiter.go
Outdated
| return fmt.Errorf("per-labelset series limit of %d exceeded (labelSet: %s, local limit: %d global limit: %d actual)", | ||
| minNonZero(err.globalLimit, err.localLimit), err.id, err.localLimit, err.globalLimit) | ||
| // per labelset limit does not have a configurable local limit like per user max series, so local limit is always zero. | ||
| return fmt.Errorf("per-labelset series limit of %d exceeded (labelSet: %s, local limit: 0 global limit: %d actual local limit: %d)", |
There was a problem hiding this comment.
nit: should we drop local limit: 0 string? I don't see much value in it if it's always 0.
There was a problem hiding this comment.
Hi @alvinlin123!,
I think it would be better to expose only one of the two: actualLocalLimit or localLimit.
There was a problem hiding this comment.
Yup I think that's a good idea to drop the "localLimit" as we don't have local limit config now for per label set series limit. We can always add it back if we decided to add the local limit. Will update this PR.
Signed-off-by: Alvin Lin <alvinlin123@gmail.com>
SungJin1212
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
See title
Which issue(s) this PR fixes:
Fixes #7009
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]