scheduler: logical plan fragmenter #7018
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rubywtl <rubyharrisonlee@gmail.com>
rubywtl
force-pushed
the
scheduler/logicalplan-fragmenter
branch
from
8b4f789 to
02fd607
Compare
yeya24
reviewed
Sep 14, 2025
|
|
||
| if len(fragments) > 0 { | ||
| return fragments, nil | ||
| } else { |
There was a problem hiding this comment.
Nit. You can remove this else as we already return above
| require.Equal(t, tc.expectedFragments, len(res)) | ||
|
|
||
| // check the metadata of the fragments of binary expressions | ||
| if len(res) == 3 { |
There was a problem hiding this comment.
Why do we need this check? This only works for the second test case?
| query: "sum(rate(http_requests_total{job=\"api\"}[5m])) + sum(rate(http_requests_total{job=\"web\"}[5m])) + sum(rate(http_requests_total{job=\"cache\"}[5m])) + sum(rate(http_requests_total{job=\"db\"}[5m]))", | ||
| start: now, | ||
| end: now, | ||
| expectedFragments: 7, |
There was a problem hiding this comment.
The test should try to compare the output fragments instead of number of fragments to be safer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR implements a logical plan fragmenter for distributed query execution. The fragmenter identifies fragments based on remote node markers in the logical plan and creates independent execution units that can be distributed across queriers. It maintains execution dependencies between parent and child fragments
Which issue(s) this PR fixes:
related to distributed query execution proposal
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]