Skip to content

Fixing get path issue where the wrong save folder could end up in the… #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fixing get path issue where the wrong save folder could end up in the… #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
</p>
<h1 align="center">Gameframe.SaveLoad 👋</h1>

<!-- BADGE-START ->
<img align="center" src="https://raw.githubusercontent.com/coryleach/UnityPackages/master/Documentation/GameframeFace.gif" />
</p>
<h1 align="center">Gameframe.SaveLoad 👋</h1>

<!-- BADGE-START -<!-- BADGE-END -->

Serialization helper utility that supports save, load and encryption.
Expand All @@ -17,15 +22,15 @@ Serialization helper utility that supports save, load and encryption.
#### Using UnityPackageManager (for Unity 2019.3 or later)
Open the package manager window (menu: Window > Package Manager)<br/>
Select "Add package from git URL...", fill in the pop-up with the following link:<br/>
https://github.com/coryleach/UnitySaveLoad.git#1.0.9<br/>
https://github.com/coryleach/UnitySaveLoad.git#1.0.10<br/>

#### Using UnityPackageManager (for Unity 2019.1 or later)

Find the manifest.json file in the Packages folder of your project and edit it to look like this:
```js
{
"dependencies": {
"com.gameframe.saveload": "https://github.com/coryleach/UnitySaveLoad.git#1.0.9",
"com.gameframe.saveload": "https://github.com/coryleach/UnitySaveLoad.git#1.0.10",
...
},
}
Expand Down
10 changes: 7 additions & 3 deletions Runtime/SaveLoadManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,16 @@ public T Copy<T>(T obj)
/// Get the full path to a save file
/// </summary>
/// <param name="filename">Name of file</param>
/// <param name="folderName">Name of folder containing file</param>
/// <param name="folder">Name of folder containing file</param>
/// <param name="streamingAssets">true if saves are from streaming assets</param>
/// <returns>full path to the file on disk</returns>
public string GetPath(string filename, string folderName = null, bool streamingAssets = false)
public string GetPath(string filename, string folder = null, bool streamingAssets = false)
{
var savePath = SaveLoadUtility.GetSavePath(folderName, baseFolder, streamingAssets);
if (string.IsNullOrEmpty(folder))
{
folder = defaultFolder;
}
var savePath = SaveLoadUtility.GetSavePath(folder, baseFolder, streamingAssets);
var saveFilename = savePath + filename;
return saveFilename;
}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "com.gameframe.saveload",
"displayName": "Gameframe.SaveLoad",
"version": "1.0.9",
"version": "1.0.10",
"description": "Serialization helper utility that supports save, load and encryption.",
"keywords": [],
"author": {
Expand Down