Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comparison methods to Decimal class #217

Merged
merged 5 commits into from
Jun 10, 2020
Merged

Add comparison methods to Decimal class #217

merged 5 commits into from
Jun 10, 2020

Conversation

willclarktech
Copy link
Contributor

Closes #214

webmaster128
webmaster128 reviewed Jun 10, 2020
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you use that here? https://github.com/CosmWasm/cosmjs/blob/master/packages/faucet/src/tokenmanager.ts#L57-L59

@willclarktech
Copy link
Contributor Author

@webmaster128 Updated, now with a public compare method. I would wait to extract the type signature until we implement the comparisons for Integer.

webmaster128
webmaster128 reviewed Jun 10, 2020
View reviewed changes
packages/faucet/src/tokenmanager.ts Show resolved Hide resolved
packages/math/src/decimal.ts Outdated Show resolved Hide resolved
@webmaster128 webmaster128 merged commit bb3cd13 into master Jun 10, 2020
@webmaster128 webmaster128 deleted the 214-decimal-comparisons branch June 10, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add comparison operators on Decimal type in @cosmjs/math
2 participants
@willclarktech @webmaster128