Improve IBC query tests #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
reviewed
Nov 4, 2020
| import { pendingWithoutSimapp, simapp } from "../testutils.spec"; | ||
| import { IbcExtension, setupIbcExtension } from "./ibc"; | ||
| import { QueryClient } from "./queryclient"; | ||
| import * as ibcTest from "./testutils.spec"; |
There was a problem hiding this comment.
I'm not convinced this is the best way to export/import and organize the testutils.spec module. We use this module name usually for all kinds of helper functions, not only data.
Can we either export all the ibc data as a single ibcData or rename the module to only contain ibc data?
willclarktech
force-pushed
the
494-ibc-query-tests
branch
from
c4baac2
to
e91098c
Compare
webmaster128
approved these changes
Nov 4, 2020
This was referenced Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 2 of #494
Merge after #509