Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom config.toml #10936

Closed
4 tasks
tac0turtle opened this issue Jan 12, 2022 · 0 comments · Fixed by #11049
Closed
4 tasks

custom config.toml #10936

tac0turtle opened this issue Jan 12, 2022 · 0 comments · Fixed by #11049
Assignees
Labels
C:CLI T: Dev UX UX for SDK developers (i.e. how to call our code) T: UX

Comments

@tac0turtle
Copy link
Member

Summary

There is no way to add custom defaults to the config.toml without forking initCmd. Similar to custom app.toml we should introduce a way to add custom config.toml settings.

Problem Definition

custom config.toml requires forking initcmd

Proposal

similar to custom app.toml work we introduce a way to change defaults but not add things to the config of tendermint.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tac0turtle tac0turtle added C:CLI T: UX T: Dev UX UX for SDK developers (i.e. how to call our code) labels Jan 12, 2022
@mergify mergify bot closed this as completed in #11049 Jan 31, 2022
mergify bot pushed a commit that referenced this issue Jan 31, 2022
## Description

Closes: #10936

avoid copy pasting init command, allow teams to overwrite config by default. 

another feature proposal

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Repository owner moved this from Todo to Done in Cosmos SDK Maintenance Jan 31, 2022
@tac0turtle tac0turtle self-assigned this Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI T: Dev UX UX for SDK developers (i.e. how to call our code) T: UX
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant