Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move generate_only and simulate to baseReq in REST txs #3056

Closed
4 tasks
fedekunze opened this issue Dec 10, 2018 · 2 comments
Closed
4 tasks

Move generate_only and simulate to baseReq in REST txs #3056

fedekunze opened this issue Dec 10, 2018 · 2 comments
Assignees
@alessio
Labels
S:proposal accepted

Comments

@fedekunze
Copy link
Collaborator

Summary

Move generate_only and simulate from query params to baseReq in POST endpoints

Proposal and Problem Definition

Currently they are set as query parameters, it'd be much simpler to move them within the baseReq with default value false. Then we won't need to parse them or have functions like HasGenerateOnlyArg and HasDryRunArg.

cc: @jackzampolin @alexanderbez @alessio

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alessio
Copy link
Contributor

alessio commented Dec 10, 2018

Fair enough, I'll take this.

@alessio alessio self-assigned this Dec 10, 2018
@fedekunze fedekunze mentioned this issue Dec 10, 2018
Merged
6 tasks
@alexanderbez
Copy link
Contributor

Yup. Seems like a cleaner approach to me. Are you implementing this or should I?

alessio pushed a commit that referenced this issue Dec 10, 2018
Move generate_only and simulate to POST body in REST txs
ac0a7c0 
Closes: #3056
@alessio alessio mentioned this issue Dec 10, 2018
Merged
5 tasks
jackzampolin added a commit that referenced this issue Dec 10, 2018
@jackzampolin
R4R: Move generate_only and simulate to POST body in REST txs (#3060)
e1f0767 
* Move generate_only and simulate to POST body in REST txs

Closes: #3056

* Run make format

* drop extra else block, outdent its block, and make linter happy

* Update PENDING.md

* Update LCD swagger docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
S:proposal accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alessio @alexanderbez @fedekunze