-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Check error for RegisterQueryHandlerClient in all modules RegisterGRPCGatewayRoutes #10439
fix: Check error for RegisterQueryHandlerClient in all modules RegisterGRPCGatewayRoutes #10439
Conversation
…khita/check-error-for-RegisterQueryHandlerClient
Codecov Report
@@ Coverage Diff @@
## master #10439 +/- ##
==========================================
- Coverage 64.24% 64.20% -0.05%
==========================================
Files 581 581
Lines 55199 55206 +7
==========================================
- Hits 35465 35447 -18
- Misses 17715 17741 +26
+ Partials 2019 2018 -1
|
…khita/check-error-for-RegisterQueryHandlerClient
…khita/check-error-for-RegisterQueryHandlerClient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, let's also add a changelog entry
…khita/check-error-for-RegisterQueryHandlerClient
Our errorcheck linter is very thankful for this 🙏 |
Description
Closes: #10437
Checks the error for
RegisterQueryHandlerClient
in all modulesRegisterGRPCGatewayRoutes
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change