Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change SimulationState.InitialStake to sdkmath.Int #11855

Merged
merged 4 commits into from
May 2, 2022

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented May 2, 2022

Description

Closes: #11795


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #11855 (335810e) into main (8076144) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11855      +/-   ##
==========================================
- Coverage   66.03%   65.97%   -0.06%     
==========================================
  Files         681      670      -11     
  Lines       71443    70717     -726     
==========================================
- Hits        47174    46654     -520     
+ Misses      21566    21394     -172     
+ Partials     2703     2669      -34     
Impacted Files Coverage Δ
simapp/state.go 0.00% <0.00%> (ø)
types/module/simulation.go 0.00% <ø> (ø)
x/auth/simulation/genesis.go 71.83% <0.00%> (ø)
x/distribution/simulation/operations.go 80.54% <0.00%> (-9.73%) ⬇️
cosmovisor/cmd/cosmovisor/run.go
cosmovisor/cmd/cosmovisor/help.go
cosmovisor/process.go
cosmovisor/cmd/cosmovisor/main.go
cosmovisor/args.go
cosmovisor/upgrade.go
... and 5 more

@facundomedica facundomedica marked this pull request as ready for review May 2, 2022 18:37
@facundomedica facundomedica requested a review from a team as a code owner May 2, 2022 18:37
@facundomedica
Copy link
Member Author

Rosetta tests seem to be failing, but I didn't messed with that (at least directly)

@alexanderbez
Copy link
Contributor

Rosetta tests seem to be failing, but I didn't messed with that (at least directly)

Yes, unrelated to this PR. Feel free to ignore it. See: #11846

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wohoo first core PR! 🎉

simapp/state.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle merged commit 78618db into main May 2, 2022
@tac0turtle tac0turtle deleted the facu/initialstake-sdkint branch May 2, 2022 22:57
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* fix: change SimulationState.InitialStake to sdkmath.Int

* cl

* aleks' suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make SimulationState accept sdk.Int as value for InitialStake.
3 participants