-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change SimulationState.InitialStake to sdkmath.Int #11855
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11855 +/- ##
==========================================
- Coverage 66.03% 65.97% -0.06%
==========================================
Files 681 670 -11
Lines 71443 70717 -726
==========================================
- Hits 47174 46654 -520
+ Misses 21566 21394 -172
+ Partials 2703 2669 -34
|
Rosetta tests seem to be failing, but I didn't messed with that (at least directly) |
Yes, unrelated to this PR. Feel free to ignore it. See: #11846 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wohoo first core PR! 🎉
* fix: change SimulationState.InitialStake to sdkmath.Int * cl * aleks' suggestion
Description
Closes: #11795
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change