Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate x/params usage in x/slashing #12399

Merged
merged 17 commits into from
Jul 6, 2022

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #12288


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 marked this pull request as ready for review July 4, 2022 04:25
@likhita-809 likhita-809 requested a review from a team as a code owner July 4, 2022 04:25
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

proto/cosmos/slashing/v1beta1/tx.proto Outdated Show resolved Hide resolved
x/slashing/module.go Show resolved Hide resolved
x/slashing/types/keys.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@likhita-809 please add a changelog entry and we can merge this 👍

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #12399 (12cfd15) into main (e7f78b4) will decrease coverage by 0.07%.
The diff coverage is 46.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12399      +/-   ##
==========================================
- Coverage   65.67%   65.59%   -0.08%     
==========================================
  Files         695      685      -10     
  Lines       72416    71635     -781     
==========================================
- Hits        47559    46990     -569     
+ Misses      22177    21999     -178     
+ Partials     2680     2646      -34     
Impacted Files Coverage Δ
x/slashing/types/keys.go 0.00% <ø> (ø)
x/slashing/types/msg.go 23.33% <0.00%> (-17.85%) ⬇️
x/slashing/types/params.go 0.00% <0.00%> (ø)
x/slashing/types/params_legacy.go 0.00% <0.00%> (ø)
x/slashing/keeper/migrations.go 33.33% <50.00%> (-16.67%) ⬇️
x/slashing/module.go 66.30% <54.54%> (-3.02%) ⬇️
x/slashing/types/codec.go 63.15% <66.66%> (+0.65%) ⬆️
x/slashing/migrations/v2/migrate.go 72.72% <72.72%> (ø)
x/slashing/keeper/params.go 84.37% <80.95%> (-3.63%) ⬇️
x/slashing/keeper/keeper.go 46.15% <100.00%> (ø)
... and 14 more

@alexanderbez alexanderbez merged commit b75c2eb into main Jul 6, 2022
@alexanderbez alexanderbez deleted the likhita/migrate-slashing-params branch July 6, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove params from x/slashing
4 participants