-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove broadcast mode block
#12659
Conversation
block
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #12659 +/- ##
==========================================
- Coverage 55.87% 54.63% -1.25%
==========================================
Files 646 671 +25
Lines 54895 57693 +2798
==========================================
+ Hits 30675 31518 +843
- Misses 21762 23635 +1873
- Partials 2458 2540 +82
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love PRs that remove code!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
back to this, sorry for the delay |
6a30d62
to
9c09965
Compare
c9586a0
to
f70b07c
Compare
ad83c0f
to
76ee504
Compare
266ed38
to
31c9df9
Compare
block
block
Great job on pushing this over the finish line @julienrbrt bravo 👏 |
Description
Closes: #12167
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change