fix: fix the cancel unbond #12967
Merged
fix: fix the cancel unbond #12967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #12967 +/- ##
==========================================
- Coverage 55.84% 55.68% -0.16%
==========================================
Files 649 644 -5
Lines 55022 54935 -87
==========================================
- Hits 30726 30591 -135
- Misses 21822 21878 +56
+ Partials 2474 2466 -8
|
atheeshp
reviewed
Aug 19, 2022
atheeshp
reviewed
Aug 19, 2022
alexanderbez
approved these changes
Aug 22, 2022
atheeshp
reviewed
Aug 22, 2022
amaury1093
reviewed
Aug 22, 2022
| @@ -130,8 +130,27 @@ func NewUnbondingDelegation( | |||
|
|
|||
| // AddEntry - append entry to the unbonding delegation | |||
| func (ubd *UnbondingDelegation) AddEntry(creationHeight int64, minTime time.Time, balance math.Int) { | |||
There was a problem hiding this comment.
let's add a unit test for this function
amaury1093
reviewed
Aug 23, 2022
| @@ -130,8 +130,27 @@ func NewUnbondingDelegation( | |||
|
|
|||
| // AddEntry - append entry to the unbonding delegation | |||
There was a problem hiding this comment.
Let's update this godoc too
|
@AmauryM I added store migrations and tests, can you please look into those changes. |
gsk967
requested review from
amaury1093 and
atheeshp
and removed request for
amaury1093 and
atheeshp
atheeshp
approved these changes
Aug 24, 2022
amaury1093
approved these changes
Aug 24, 2022
amaury1093
added
the
A:automerge
amaury1093
added
backport/0.46.x
Wryhder
pushed a commit
to Wryhder/cosmos-sdk
that referenced
this pull request
Oct 26, 2022
## Description This pull request contains the fix regarding cancel unbonding delegations It will remove duplicate ubdEntries which have same `creation_height` and create new ubdEntry with updated `balance` and `initial_balance` Closes: cosmos#12931 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
This was referenced May 5, 2023
5 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request contains the fix regarding cancel unbonding delegations
It will remove duplicate ubdEntries which have same
creation_heightand create new ubdEntry with updatedbalanceandinitial_balanceCloses: #12931
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change