refactor!: simplify cosmos.reflection.v1 #13668
Conversation
| // pagination defines the optional pagination request. | ||
| cosmos.base.query.v1beta1.PageRequest pagination = 1; | ||
| } | ||
| message FileDescriptorsRequest {} |
There was a problem hiding this comment.
aaronc
added
the
T: Proto Breaking
|
This is proto breaking, but unreleased |
It could be an issue but pagination only helps with single request size not total server load. If someone wants the file descriptors, they want them all. It's not like a UI paging thing, so pagination is really overkill. This is the type of method a server might want some rate limiting around. I will check the size of the SDK's descriptors. |
|
The SDK's |
|
Anyone know why proto break check is not a required check? I'm surprised this merged without me needing to manually override that 😱 |
|
Tagging |
|
Its fine to have Proto breakage land on main, having it be required may slow down some merges |
Yes, but it could also allow unintended breakage. I thought we had problems with that before |
|
I cant remember when that was an issue since proto breaking usually means migrations |
|
Description
Follow-up to #13597 so I don't need a go.mod
replacein #13281Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change