Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): remove header dependence from tests #16342

Merged
merged 10 commits into from
May 31, 2023
Merged

Conversation

tac0turtle
Copy link
Member

Description

this pr removes all instances of cmtproto.Header{} in tests. Since it is an empty header it is best we dont rely on the type from comet at all for these


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@@ -32,7 +32,7 @@ func BeginBlocker(k *keeper.Keeper, ctx sdk.Context) {
// 1. If there is no scheduled upgrade.
// 2. If the plan is not ready.
// 3. If the plan is ready and skip upgrade height is set for current height.
if !found || !plan.ShouldExecute(ctx) || (plan.ShouldExecute(ctx) && k.IsSkipHeight(ctx.BlockHeight())) {
if !found || !plan.ShouldExecute(ctx) || (plan.ShouldExecute(ctx) && k.IsSkipHeight(ctx.HeaderInfo().Height)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future this would use the header service instead of headerInfo from context. This will happen we we do further integration with core api

@tac0turtle tac0turtle marked this pull request as ready for review May 31, 2023 09:53
@tac0turtle tac0turtle requested a review from a team as a code owner May 31, 2023 09:53
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, few nits.

baseapp/test_helpers.go Outdated Show resolved Hide resolved
baseapp/test_helpers.go Outdated Show resolved Hide resolved
baseapp/test_helpers.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle added this pull request to the merge queue May 31, 2023
Merged via the queue into main with commit 5097b0c May 31, 2023
@tac0turtle tac0turtle deleted the marko/contextlegacy branch May 31, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants