Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(distribution)!: use collections for validator accumulated commission state #16571

Merged

Conversation

testinginprod
Copy link
Contributor

@testinginprod testinginprod commented Jun 15, 2023

Description

Closes: #16572


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:Simulations C:x/distribution distribution module related labels Jun 15, 2023
@testinginprod testinginprod marked this pull request as ready for review June 15, 2023 10:49
@testinginprod testinginprod requested a review from a team as a code owner June 15, 2023 10:49
@testinginprod testinginprod added this pull request to the merge queue Jun 15, 2023
Merged via the queue into main with commit 99913cd Jun 15, 2023
@testinginprod testinginprod deleted the tip/distribution/coll_validator_accumulated_commission branch June 15, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Simulations C:x/distribution distribution module related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(distribution): use collections for ValidatorAccumulatedCommission state
2 participants