Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR Template Admin Section #1669

Merged
merged 1 commit into from
Jul 13, 2018
Merged

PR Template Admin Section #1669

merged 1 commit into from
Jul 13, 2018

Conversation

rigelrozanski
Copy link
Contributor

N/A

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated Gaia/Examples
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)

@rigelrozanski rigelrozanski changed the title PR template cleanup / Add Admin section PR Template Admin Section Jul 13, 2018
@rigelrozanski rigelrozanski added ready-for-review T:Docs Changes and features related to documentation. labels Jul 13, 2018
@codecov
Copy link

codecov bot commented Jul 13, 2018

Codecov Report

Merging #1669 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1669   +/-   ##
=======================================
  Coverage   62.84%   62.84%           
=======================================
  Files         124      124           
  Lines        6992     6992           
=======================================
  Hits         4394     4394           
  Misses       2346     2346           
  Partials      252      252

cwgoes
cwgoes approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Maybe we should disable the automatic CODEOWNERS review requests in favor of more targeted reviewer selection.

@cwgoes cwgoes merged commit 80f4875 into master Jul 13, 2018
@cwgoes cwgoes deleted the rigel/PR-template-update branch July 13, 2018 17:17
@ValarDragon
Copy link
Contributor

Awesome! Glad we're adopting assigning reviewers.

@ValarDragon ValarDragon mentioned this pull request Jul 16, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rigelrozanski @ValarDragon @cwgoes