Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Params cleanup #1684

Closed
wants to merge 1 commit into from
Closed

WIP: Params cleanup #1684

wants to merge 1 commit into from

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Jul 14, 2018

  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes added the wip label Jul 14, 2018
@codecov
Copy link

codecov bot commented Jul 14, 2018

Codecov Report

Merging #1684 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1684   +/-   ##
=======================================
  Coverage   62.07%   62.07%           
=======================================
  Files         116      116           
  Lines        6929     6929           
=======================================
  Hits         4301     4301           
  Misses       2385     2385           
  Partials      243      243

@ebuchman ebuchman changed the base branch from master to develop July 16, 2018 15:35
@ValarDragon ValarDragon mentioned this pull request Jul 16, 2018
Open
@cwgoes
Copy link
Contributor Author

cwgoes commented Jul 17, 2018

Closing in favor of #1704.

@cwgoes cwgoes closed this Jul 17, 2018
@cwgoes cwgoes deleted the cwgoes/params-cleanup branch July 17, 2018 00:07
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
@dependabot
Bump actions/cache from 3.0.7 to 3.0.8 (cosmos#1684)
d6684e6 
Bumps [actions/cache](https://github.com/actions/cache) from 3.0.7 to 3.0.8.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.0.7...v3.0.8)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cwgoes