Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/distribution)!: migrate to collections #17115

Merged
merged 23 commits into from
Jul 31, 2023

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented Jul 24, 2023

Description

Closes: #17114 and #16367

  • We need to tag collections
  • Added WithCollectionPaginationTriplePrefix in types/query
  • I have doubts regarding PreviousProposer. Should we do a migration (like in this PR) or an AltCodec that can decode the current and previous formats?

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:x/distribution distribution module related label Jul 24, 2023
},
)
},
"ab1b97a106410d9848a690286293c1ec7dfb63354dff6996152a49935d226250")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proved to be useful 💪, will remove it from this pr tho

x/distribution/keeper/store.go Fixed Show fixed Hide fixed
x/distribution/keeper/store.go Fixed Show fixed Hide fixed
x/distribution/keeper/store.go Fixed Show fixed Hide fixed
x/distribution/abci.go Fixed Show fixed Hide fixed
@facundomedica facundomedica changed the title refactor!(distr): migrate to collections refactor!(distribution): migrate to collections Jul 25, 2023
@facundomedica facundomedica marked this pull request as ready for review July 25, 2023 13:45
@facundomedica facundomedica requested a review from a team as a code owner July 25, 2023 13:45
@julienrbrt julienrbrt changed the title refactor!(distribution): migrate to collections refactor(x/distribution)!: migrate to collections Jul 25, 2023
go.mod Outdated Show resolved Hide resolved
simapp/go.mod Outdated Show resolved Hide resolved
tests/go.mod Outdated Show resolved Hide resolved
@testinginprod
Copy link
Contributor

I don't think we can use AltValueCodec here, the reason is simple, AltValueCodec will prioritise sdk.ConsAddress which is bytes, since it's arbitrary bytes even the gogoproto.Uint64Value bytes can fit in, which means that the alternative decoding will never be used. 😢

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly changelog nits lol.

x/distribution/keeper/store.go Show resolved Hide resolved
x/distribution/keeper/store.go Show resolved Hide resolved
x/distribution/keeper/store.go Show resolved Hide resolved
x/distribution/keeper/store.go Show resolved Hide resolved
x/distribution/keeper/store.go Show resolved Hide resolved
x/distribution/migrations/v4/migrate.go Show resolved Hide resolved
x/distribution/keeper/validator.go Outdated Show resolved Hide resolved
x/distribution/module.go Outdated Show resolved Hide resolved
@facundomedica facundomedica added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit 60605de Jul 31, 2023
48 checks passed
@facundomedica facundomedica deleted the facu/migrate-distr-colls branch July 31, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/distribution distribution module related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor(distribution): Migrate ValidatorSlashEvent to collections
3 participants