-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/distribution)!: migrate to collections #17115
Conversation
x/distribution/keeper/keeper_test.go
Outdated
}, | ||
) | ||
}, | ||
"ab1b97a106410d9848a690286293c1ec7dfb63354dff6996152a49935d226250") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This proved to be useful 💪, will remove it from this pr tho
…/migrate-distr-colls
I don't think we can use AltValueCodec here, the reason is simple, AltValueCodec will prioritise sdk.ConsAddress which is bytes, since it's arbitrary bytes even the gogoproto.Uint64Value bytes can fit in, which means that the alternative decoding will never be used. 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly changelog nits lol.
…/migrate-distr-colls
Co-authored-by: Julien Robert <julien@rbrt.fr>
…cosmos-sdk into facu/migrate-distr-colls
Description
Closes: #17114 and #16367
WithCollectionPaginationTriplePrefix
in types/queryAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change