-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(x/staking): migrate UnbondingType to collections #17248
Conversation
…ita/ubdtype-coll
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look backwards compatible, we should store a uint64
instead of int64
.
-- KEY: 390000000000000063 Value: 0000000000000001
++ KEY: 390000000000000063 Value: 8000000000000001
I suggest you check with this to find if your changes are compatible:
func (s *KeeperTestSuite) TestColls() {
s.SetupTest()
err := sdktestutil.DiffCollectionsMigration(
s.ctx,
s.key,
100,
func(i int64) {
err := s.stakingKeeper.SetUnbondingType(
s.ctx,
uint64(i),
types.UnbondingType_UnbondingDelegation,
)
s.Require().NoError(err)
},
"{insert original hash here}",
)
s.Require().NoError(err)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe not for this PR but it would be good to explore the possibility to make UnbondingType a uint64 instead of int, so we don't have to type cast and we wouldn't need GetUnbondingType and SetUnbondingType.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK, one nit.
…ita/ubdtype-coll
…os-sdk into likhita/ubdtype-coll
Could you fix the conflicts? |
…ita/ubdtype-coll
Description
Closes: #16388
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change