Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move CommunityPool to its own module #17657

Merged
merged 142 commits into from
Sep 27, 2023
Merged

feat: Move CommunityPool to its own module #17657

merged 142 commits into from
Sep 27, 2023

Conversation

likhita-809
Copy link
Contributor

@likhita-809 likhita-809 commented Sep 7, 2023

Description

Closes: #10811

This PR does the following:

  • Makes a separate pool module on its own to handle community pool services
  • Completely removes the dependency of x/distribution module in x/gov
  • Removes CLI cmds related to pool in x/distribution client cmds i.e., fund-community-pool cmd
  • Adds new msg service and grpc query routers in x/distribution to handle community pool msg and query services

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:x/gov C:x/distribution distribution module related labels Sep 7, 2023
@julienrbrt
Copy link
Member

I know the PR isn't ready, but just a small note already, we need to follow this check-list when adding a new go.mod: https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#gomod

simapp/app.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
tests/integration/rapidgen/rapidgen.go Show resolved Hide resolved
tests/starship/tests/go.mod Outdated Show resolved Hide resolved
testutil/configurator/configurator.go Show resolved Hide resolved
x/gov/testutil/expected_keepers.go Outdated Show resolved Hide resolved
x/protocolpool/README.md Show resolved Hide resolved
x/protocolpool/go.mod Outdated Show resolved Hide resolved
x/protocolpool/keeper/keeper.go Outdated Show resolved Hide resolved
x/protocolpool/module.go Show resolved Hide resolved
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀
Just missing the nit for proposal simulations.

@tac0turtle tac0turtle added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit 9dd3451 Sep 27, 2023
57 of 58 checks passed
@tac0turtle tac0turtle deleted the likhita/pool branch September 27, 2023 09:11
@fedekunze
Copy link
Collaborator

the fund community pool message should be removed in favour of just using a send transaction. Have you consider this as part of this implementation?

@julienrbrt
Copy link
Member

julienrbrt commented Sep 27, 2023

the fund community pool message should be removed in favour of just using a send transaction. Have you consider this as part of this implementation?

That's the case now, x/protocolpool is just a module account. We theoretically do not need the MsgFundCommunityPool message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move community pool into its own module
10 participants