-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move CommunityPool to its own module #17657
Conversation
I know the PR isn't ready, but just a small note already, we need to follow this check-list when adding a new go.mod: https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#gomod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🚀
Just missing the nit for proposal simulations.
the fund community pool message should be removed in favour of just using a send transaction. Have you consider this as part of this implementation? |
That's the case now, x/protocolpool is just a module account. We theoretically do not need the MsgFundCommunityPool message. |
Description
Closes: #10811
This PR does the following:
fund-community-pool
cmdAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
make lint
andmake test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change